o2w/talon
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Utilising the Constants

Browse Source 
Checking for the length of a line to determine if it is possibly a signature or not could be done
in a more generic way by determining the maximum size of the line via a constant. Hence advocating
the spirit of the modifying the code in only one place and propagating that change everywhere.

This exact approach has already been used at:
This commit is contained in:
Tarek Sheasha
2015-01-21 15:54:57 +01:00
parent 3768d7ba31
commit 13dc43e960
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
talon/signature/learning/featurespace.py
View File

@@ -7,7 +7,8 @@ The body and the message sender string are converted into unicode before
applying features to them. applying features to them.
""" """
from talon.signature.constants import SIGNATURE_MAX_LINES from talon.signature.constants import (SIGNATURE_MAX_LINES,
TOO_LONG_SIGNATURE_LINE)
from talon.signature.learning.helpers import * from talon.signature.learning.helpers import *
@@ -20,7 +21,7 @@ def features(sender=''):
# This one is not from paper. # This one is not from paper.
# Line is too long. # Line is too long.
# This one is less aggressive than `Line is too short` # This one is less aggressive than `Line is too short`
lambda line: 1 if len(line) > 60 else 0, lambda line: 1 if len(line) > TOO_LONG_SIGNATURE_LINE else 0,
# Line contains email pattern. # Line contains email pattern.
binary_regex_search(RE_EMAIL), binary_regex_search(RE_EMAIL),
# Line contains url. # Line contains url.